patsonluk opened a new pull request, #2076: URL: https://github.com/apache/solr/pull/2076
https://issues.apache.org/jira/browse/SOLR-17076 # Description `OrderedNodePlacementPlugin#getAllReplicasOnNode` can be slow in a cluster with lot of replicas. The effect could compound with new collection creation with many shards. # Solution Introduced a new field `allReplicas` which keeps track of all the replicas added/removed in the Plugin. Return a copy of that set instead for `getAllReplicasOnNode`. Also added a new convenient method `getAllReplicaCount` if only the count is needed # Tests A minor change, rely on existing unit test case # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
