janhoy commented on PR #2059: URL: https://github.com/apache/solr/pull/2059#issuecomment-1792091597
Ok, I forgot that I already had #1904 already open with almost exactly same changes. Well, double work there 🤣 In that PR I chose to keep the Base test-class in order to minimize merge conflicts for future CB backports. But I wonder if git manages to do the right thing, understanding that the `BaseTestCircuitBreaker` class was renamed `TestCircuitBreaker`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org