cpoerschke commented on PR #2030:
URL: https://github.com/apache/solr/pull/2030#issuecomment-1779181373
Hi Florin!
Thanks for opening this pull request, with a test and scoped to only change
the learning-to-rank model store.
I've added a commit with minor tweaks, feel free to revert or amend.
Taking a step back from the code, here's a couple of thoughts or questions:
* Do we need to consider backwards compatibility i.e. existing storage
behaviour changing and/or how to communicate the change in the upgrade notes?
* Might some users prefer the existing behaviour i.e. more storage space but
also more human readable?
* Would consistency between the LTR model store and the LTR feature store be
helpful?
* Might it be possible to support both the existing and the new behaviour?
* A system property e.g. `-Dsolr.ltr.model-store.indentSize=2` and
`-Dsolr.ltr.feature-store.indentSize=2` perhaps?
* A configurable somehow, how?
* A parameter that is passed during upload e.g. different models could
have different indentation?
* An alternative endpoint for uploading?
* Something else?
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
