[ 
https://issues.apache.org/jira/browse/SOLR-17046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777488#comment-17777488
 ] 

Chris M. Hostetter commented on SOLR-17046:
-------------------------------------------

If people feel like pursuing this, one concern I have with changing the default 
Codec implicitly is that we'll want to make *_absolutely_* certain that the 
"default" behavior of {{SchemaCodecFactory}} (ie: w/o any explicitly 
configuration) doesn't fall behind the Lucene defaults as progress moves 
forward.

Example: we don't want {{SchemaCodecFactory}} to still be using a subclasses of 
{{Lucene95Codec}} or {{Lucene95HnswVectorsFormat}} if {{Codec.getDefault()}} 
now returns some new {{{}HuperDuperCodec{}}}.

Ideally we should have a test that confirms the {{Codec}} returned by 
{{SchemaCodecFactory}} extends whatever class is returned by 
{{{}Codec.getDefault(){}}}, and likewise loop over all of the public methods in 
the {{Codec}} API (using reflection in case new methods are added) checking the 
classes/inheritance relationship of them as well.

> SchemaCodecFactory should be the implicit default if no <codeFactory/> is 
> configured
> ------------------------------------------------------------------------------------
>
>                 Key: SOLR-17046
>                 URL: https://issues.apache.org/jira/browse/SOLR-17046
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Chris M. Hostetter
>            Priority: Major
>
> Solr has a {{SchemaCodecFactory}} that enables may Solr {{FieldType}} impls 
> to customize the behavior of of the indexing codec -- but unless it is 
> explicitly configured in {{solrconfig.xml}}, the Lucene 
> {{Codec.getDefault()}} is used in it's place.
> We should consider changing the behavior of Solr so that the implicit 
> {{<codecFactory/>}} is {{SchemaCodecFactory}}, and offer a (new) 
> {{LuceneDefaultCodecFactory}} that users can configure if there have any 
> strong reason for not wanting to support the per-field configurability of 
> {{SchemaCodecFactory}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to