bruno-roustant commented on PR #2012: URL: https://github.com/apache/solr/pull/2012#issuecomment-1768115201
Thanks Alex for the review and questions. Good point with the indexing benchmark. So I ran it to confirm there is no perf impact. I ran the benchmark twice with the current code (baseline): ``` # Run complete. Total time: 00:25:22 Benchmark (nodeCount) (numReplicas) (numShards) (preGenerate) (useSmallDocs) Mode Cnt Score Error Units CloudIndexing.indexDoc 4 1 4 50000 true thrpt 4 8167.548 ± 5407.518 ops/s CloudIndexing.indexDoc 4 1 4 50000 false thrpt 4 664.634 ± 207.693 ops/s CloudIndexing.indexDoc 4 3 4 50000 true thrpt 4 3153.489 ± 2220.162 ops/s CloudIndexing.indexDoc 4 3 4 50000 false thrpt 4 196.909 ± 168.691 ops/s ``` ``` # Run complete. Total time: 00:26:35 Benchmark (nodeCount) (numReplicas) (numShards) (preGenerate) (useSmallDocs) Mode Cnt Score Error Units CloudIndexing.indexDoc 4 1 4 50000 true thrpt 4 7850.734 ± 7853.495 ops/s CloudIndexing.indexDoc 4 1 4 50000 false thrpt 4 718.769 ± 144.427 ops/s CloudIndexing.indexDoc 4 3 4 50000 true thrpt 4 3121.904 ± 1488.081 ops/s CloudIndexing.indexDoc 4 3 4 50000 false thrpt 4 208.965 ± 279.114 ops/s ``` And I ran the benchmark twice with the new code: ``` # Run complete. Total time: 00:25:34 Benchmark (nodeCount) (numReplicas) (numShards) (preGenerate) (useSmallDocs) Mode Cnt Score Error Units CloudIndexing.indexDoc 4 1 4 50000 true thrpt 4 7987.105 ± 7236.395 ops/s CloudIndexing.indexDoc 4 1 4 50000 false thrpt 4 720.472 ± 240.961 ops/s CloudIndexing.indexDoc 4 3 4 50000 true thrpt 4 3337.063 ± 2887.649 ops/s CloudIndexing.indexDoc 4 3 4 50000 false thrpt 4 199.760 ± 288.116 ops/s ``` ``` # Run complete. Total time: 00:26:27 Benchmark (nodeCount) (numReplicas) (numShards) (preGenerate) (useSmallDocs) Mode Cnt Score Error Units CloudIndexing.indexDoc 4 1 4 50000 true thrpt 4 7851.275 ± 5788.400 ops/s CloudIndexing.indexDoc 4 1 4 50000 false thrpt 4 741.718 ± 158.800 ops/s CloudIndexing.indexDoc 4 3 4 50000 true thrpt 4 3034.854 ± 2308.357 ops/s CloudIndexing.indexDoc 4 3 4 50000 false thrpt 4 210.943 ± 254.704 ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
