Re: [PR] SOLR-17022: Support for glob patterns for fields in Export handler, Stream handler and with SelectStream streaming expression [solr]

[via GitHub]

justinrsweeney commented on code in PR #1996:
URL: https://github.com/apache/solr/pull/1996#discussion_r1353089056


##########
solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java:
##########
@@ -27,9 +27,14 @@
 import java.io.PrintWriter;
 import java.lang.invoke.MethodHandles;
 import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
+import java.util.Set;
 import java.util.TreeSet;
+import org.apache.commons.io.FilenameUtils;

Review Comment:
   This PR does add that as a dependency in solrj for the SelectStream 
expression, could evaluate alternate options there is that is undesirable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org