gerlowskija commented on PR #1978: URL: https://github.com/apache/solr/pull/1978#issuecomment-1747451445
❗ ❗ **Naming Emergency** ❗ ❗ Many v2 APIs are currently offered at two paths based on whether a user is providing a core or a collection name. For example, schema APIs are available at both `/collections/techproducts/schema` and `/cores/techproducts_shard1_replica_n1/schema` Trying to define these APIs concisely puts us in the awkward place of needing a generic term for either a core or a collection. So far in this PR I've made due with "index", but I'm not terribly happy with it. This choice appears in a few places: - JAX-RS annotations e.g. `@Path("/{indexType:collections|cores}/{indexName}/schema")` - Committed Java code (mostly constants) e.g. `public static final String INDEX_NAME_PATH_PARAMETER = "indexName";` - Generated SolrRequest classes e.g. `public GetSchemaName(IndexType indexType, String indexName) { ... }` It's a somewhat consequential naming decision, as it'll recur in the generated SolrJ code for most of our per core-or-collection APIs: `/schema`, `/config`, `/select`, `/update`, etc. Do we already have some generic term to refer to a core or collection? Does anyone have any good ideas? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org