gerlowskija commented on PR #629: URL: https://github.com/apache/solr-operator/pull/629#issuecomment-1739831303
Thinking on this a bit more, are we sure we want to use `/admin/info/health` for readiness probes? Unlike the `/system`, `/health` will return an error on nodes with bad ZK connections and prevent them from receiving traffic if ZK goes down. That makes sense for lots of traffic like admin requests or updates - no point sending any of those requests to a SolrCloud node that has no ZK. But it'll block other traffic that would've succeeded too - like queries, which Solr can sometimes continue to serve even without ZK. Overall I think the additional intelligence and fidelity that `/health` gives us as a readiness probe is worth this slight degradation in how we'd route traffic in response to a total catastrophe. Just wanted to call it out in case others disagree. I'll add a sentence or two documenting this aspect of things and then merge, but I'll leave this out here for a few more days to give folks a chance to chime in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
