patsonluk commented on PR #1945: URL: https://github.com/apache/solr/pull/1945#issuecomment-1736094233
> This seems to be a promising performance improvement. > > Now, I wonder if this should be extended to the generic `waitForState()` method instead of only `getLeaderWithRetry()`. We could check the predicate first once without creating watchers, and fallback to current mechanism if the predicate is not true. +1 on this. I think in general we can quickly check the `clusterState` field, give that to the `predicate` and see if it's happy, if not then proceed down to the "install watch" path? 😊 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
