epugh commented on code in PR #1954:
URL: https://github.com/apache/solr/pull/1954#discussion_r1336409323


##########
solr/core/src/java/org/apache/solr/cli/DeleteTool.java:
##########
@@ -102,13 +110,18 @@ public void runImpl(CommandLine cli) throws Exception {
   }
 
   protected void deleteCollection(CommandLine cli) throws Exception {
+    Http2SolrClient.Builder builder =
+        new Http2SolrClient.Builder()
+            .withIdleTimeout(30, TimeUnit.SECONDS)
+            .withConnectionTimeout(15, TimeUnit.SECONDS);
+    if (cli.hasOption("credentials")) {

Review Comment:
   I would be up for that...   Definitly need some sort of better way of 
dealing with this.   Maybe some more refactoring and move the method to 
`SolrCLI` instead of it being all over the place on the individual tools?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to