[
https://issues.apache.org/jira/browse/SOLR-16985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768903#comment-17768903
]
Alex Deparvu edited comment on SOLR-16985 at 9/25/23 8:44 PM:
--------------------------------------------------------------
first stab using RC1
{noformat}
> Task :solr:core:compileJava
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:197:
error: cannot find symbol
if (dimension > FloatVectorValues.MAX_DIMENSIONS) {
^
symbol: variable MAX_DIMENSIONS
location: class FloatVectorValues
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:203:
error: cannot find symbol
FloatVectorValues.MAX_DIMENSIONS);
^
symbol: variable MAX_DIMENSIONS
location: class FloatVectorValues
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:208:
error: cannot find symbol
if (dimension > ByteVectorValues.MAX_DIMENSIONS) {
^
symbol: variable MAX_DIMENSIONS
location: class ByteVectorValues
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:214:
error: cannot find symbol
ByteVectorValues.MAX_DIMENSIONS);
^
symbol: variable MAX_DIMENSIONS
location: class ByteVectorValues
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:69:
error: SlowCompositeReaderWrapper is not abstract and does not override
abstract method searchNearestVectors(String,byte[],KnnCollector,Bits) in
LeafReader
public final class SlowCompositeReaderWrapper extends LeafReader {
^
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:371:
error: searchNearestVectors(String,float[],int,Bits,int) in
SlowCompositeReaderWrapper cannot override
searchNearestVectors(String,float[],int,Bits,int) in LeafReader
public TopDocs searchNearestVectors(
^
overridden method is final
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:377:
error: searchNearestVectors(String,byte[],int,Bits,int) in
SlowCompositeReaderWrapper cannot override
searchNearestVectors(String,byte[],int,Bits,int) in LeafReader
public TopDocs searchNearestVectors(
^
overridden method is final
{noformat}
Replacing FloatVectorValues.MAX_DIMENSIONS and ByteVectorValues.MAX_DIMENSIONS
with KnnVectorsFormat.DEFAULT_MAX_DIMENSIONS
was (Author: alex.parvulescu):
first stab using RC1
{noformat}
> Task :solr:core:compileJava
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:197:
error: cannot find symbol
if (dimension > FloatVectorValues.MAX_DIMENSIONS) {
^
symbol: variable MAX_DIMENSIONS
location: class FloatVectorValues
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:203:
error: cannot find symbol
FloatVectorValues.MAX_DIMENSIONS);
^
symbol: variable MAX_DIMENSIONS
location: class FloatVectorValues
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:208:
error: cannot find symbol
if (dimension > ByteVectorValues.MAX_DIMENSIONS) {
^
symbol: variable MAX_DIMENSIONS
location: class ByteVectorValues
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:214:
error: cannot find symbol
ByteVectorValues.MAX_DIMENSIONS);
^
symbol: variable MAX_DIMENSIONS
location: class ByteVectorValues
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:69:
error: SlowCompositeReaderWrapper is not abstract and does not override
abstract method searchNearestVectors(String,byte[],KnnCollector,Bits) in
LeafReader
public final class SlowCompositeReaderWrapper extends LeafReader {
^
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:371:
error: searchNearestVectors(String,float[],int,Bits,int) in
SlowCompositeReaderWrapper cannot override
searchNearestVectors(String,float[],int,Bits,int) in LeafReader
public TopDocs searchNearestVectors(
^
overridden method is final
/Users/alexdeparvu/git/solr/solr/solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:377:
error: searchNearestVectors(String,byte[],int,Bits,int) in
SlowCompositeReaderWrapper cannot override
searchNearestVectors(String,byte[],int,Bits,int) in LeafReader
public TopDocs searchNearestVectors(
^
overridden method is final
{noformat}
> Upgrade Lucene to 9.8.0
> -----------------------
>
> Key: SOLR-16985
> URL: https://issues.apache.org/jira/browse/SOLR-16985
> Project: Solr
> Issue Type: Task
> Reporter: Alex Deparvu
> Priority: Blocker
> Fix For: 9.4
>
>
> Apache Lucene 9.8.0 was recently released: _TODO fill in link once Lucene is
> released_
> This ticket is to upgrade Solr's Lucene dependency from 9.7.0 to the latest
> 9.8.0 version.
> new or existing contributors interested in this ticket:
> * please take a look at the documentation to see what's involved:
> [[https://github.com/apache/solr/blob/main/dev-docs/lucene-upgrade.md]]
> * optional: add a short note on this ticket to share your intention to work
> on this
> * make the upgrade changes (and of course do feel free to ask any questions
> that may arise)
> * open a pull request
> Solr committers, please could you:
> * help review/merge/backport etc. the pull request for this ticket
> * try and leave the upgrade itself as an opportunity for someone else to
> also contribute to the project
> See SOLR-16799 for previous upgrades
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
