[GitHub] [solr] janhoy commented on a diff in pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

[via GitHub]

janhoy commented on code in PR #1871:
URL: https://github.com/apache/solr/pull/1871#discussion_r1315609098


##########
solr/core/src/test-files/solr/collection1/conf/solrconfig-pluggable-circuitbreaker.xml:
##########
@@ -80,6 +80,18 @@
 
   <circuitBreaker class="solr.MemoryCircuitBreaker">
     <double  name="threshold">75</double>
+    <arr name="requestTypes">
+      <str>update</str>
+    </arr>
+  </circuitBreaker>
+
+  <circuitBreaker class="solr.MemoryCircuitBreaker">
+    <double  name="threshold">80</double>
+<!-- Default is search

Review Comment:
   ```suggestion
   <!-- Default is query
   ```



##########
solr/core/src/test-files/solr/collection1/conf/solrconfig-pluggable-circuitbreaker.xml:
##########
@@ -80,6 +80,18 @@
 
   <circuitBreaker class="solr.MemoryCircuitBreaker">
     <double  name="threshold">75</double>
+    <arr name="requestTypes">
+      <str>update</str>
+    </arr>
+  </circuitBreaker>
+
+  <circuitBreaker class="solr.MemoryCircuitBreaker">
+    <double  name="threshold">80</double>
+<!-- Default is search
+    <arr name="requestTypes">
+      <str>search</str>

Review Comment:
   ```suggestion
         <str>query</str>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org