janhoy commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1310168797
##########
solr/core/src/test/org/apache/solr/util/BaseTestCircuitBreaker.java:
##########
@@ -193,6 +195,55 @@ public void testFakeCPUCircuitBreaker() {
}
}
+ public void testFakeLoadAverageCircuitBreaker() {
+ removeAllExistingCircuitBreakers();
+
+ CircuitBreaker circuitBreaker = new FakeLoadAverageCircuitBreaker();
+ LoadAverageCircuitBreaker loadAverageCircuitBreaker =
+ (LoadAverageCircuitBreaker) circuitBreaker;
+
+ loadAverageCircuitBreaker.setThreshold(75);
+
+ h.getCore().getCircuitBreakerRegistry().register(circuitBreaker);
Review Comment:
Lots of code duplication here across three different tests. Will factor out
an assert method for these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
