stillalex commented on code in PR #1835:
URL: https://github.com/apache/solr/pull/1835#discussion_r1291846493
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/CommitStream.java:
##########
@@ -55,6 +55,7 @@ public class CommitStream extends TupleStream implements
Expressible {
private TupleStream tupleSource;
private transient SolrClientCache clientCache;
+ private transient boolean isCloseCache;
Review Comment:
sorry @risdenk I misread your question. in this case no, you can't get rid
of the flag because if the cache is not null you don't know if it came from the
context (via setStreamContext method) or it was created locally (in the open
method). if it came from the context it's reused for multiple streams so you
can't close it here, you have to close it at the parent location where it was
created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
