epugh commented on PR #1826: URL: https://github.com/apache/solr/pull/1826#issuecomment-1669382550
> While I do understand the reasoning, I'm not a big fan of having an integration test rely on connection to the internet... I totally suspected this would come up.... I also don't love that we are referencing some random package created by some random person too! While the "right" thing is to maybe have some sort of test package that exercises all the aspects of package management, and that is maybe part of Apache Solr as well, I don't really have the energy/interest to go down that path. Are you a 0 or a -1 on this PR? I.e, can we live with it for now or do you think to merge we need to deal with it? One more idea, what if we comment out the test, so at least we have it someone wants to run it, but it isn't in the regular path? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
