epugh commented on code in PR #1810:
URL: https://github.com/apache/solr/pull/1810#discussion_r1278016018
##########
solr/core/src/test/org/apache/solr/cloud/LeaderElectionTest.java:
##########
@@ -258,8 +258,8 @@ public void testCancelElection() throws Exception {
Thread.sleep(1000);
String urlScheme = zkStateReader.getClusterProperty(URL_SCHEME, "http");
- String url1 = Utils.getBaseUrlForNodeName("127.0.0.1:80_solr/1",
urlScheme) + "/";
- String url2 = Utils.getBaseUrlForNodeName("127.0.0.1:80_solr/2",
urlScheme) + "/";
+ String url1 = Utils.getBaseUrlForNodeName("127.0.0.1:80_solr/1",
urlScheme) + "/" + "1" + '/';
Review Comment:
I have some concerns about how this test works.... I kind of worked around
it, however the naming of the urls for leader election seemed "odd".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
