epugh commented on code in PR #1808:
URL: https://github.com/apache/solr/pull/1808#discussion_r1276296189


##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -445,8 +450,31 @@ private static void printHelp() {
     print("Pass -help or -h after any COMMAND to see command-specific usage 
information,");
     print("such as:    ./solr start -help or ./solr stop -h");
   }
+
+  /**
+   * Strips off the end of solrUrl any /solr when a legacy solrUrl like 
http://localhost:8983/solr
+   * is used, and warns those users. In the future we'll have url's with /api 
as well.
+   *
+   * @param solrUrl with /solr stripped off.
+   * @return the truncated if need solrUrl.
+   */
+  public static String resolveSolrUrl(String solrUrl) {
+    if (solrUrl != null) {
+      if (solrUrl.indexOf("/solr") > -1) { //
+        solrUrl = solrUrl.substring(0, solrUrl.indexOf("/solr"));
+        CLIO.out(
+            "The solrUrl parameter only needs to only point to the root of 
Solr ("

Review Comment:
   Love it... pushing up fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to