osyoyu opened a new pull request, #1809: URL: https://github.com/apache/solr/pull/1809
REPLICATION metric keys start with REPLICATION./replication, not REPLICATION.replication (note the slash). This config change will let prometheus-exporter not ignore REPLICATION metrics. # Description The Prometheus exporter config provided with Solr seems to unintentionally ignore replication-related metrics. This change lets the Prometheus exporter correctly collect/expose them. # Solution Fix the regex that intends to match REPLICATION category metrics. REPLICATION metrics start with `REPLICATION./replication`, but the previous regex misses the `/` (slash) and fails to match them. # Tests Start a `solr-exporter` process and make a request to `http://localhost:9983/metrics` and confirm metrics such as `solr_metrics_core_replication_leader` or `solr_metrics_core_requests_total{category="REPLICATION"}` show up. ``` $ cd solr/packaging/build/dev $ ./bin/solr start -f $ ./bin/solr create -c films -s 2 -rf 2 # in an another shell $ ./prometheus-exporter/bin/solr-exporter -f ../../../prometheus-exporter/build/packaging/conf/solr-exporter-config.xml --baseurl http://localhost:8983/solr # another shell $ curl -s http://localhost:8989 | grep REPLICATION solr_metrics_core_replication_leader{category="REPLICATION",handler="/replication",core="films",base_url="http://localhost:8983/solr",cluster_id="a8ed8a12b2",} 1.0 solr_metrics_core_requests_total{category="REPLICATION",handler="/replication",internal="false",core="films",base_url="http://localhost:8983/solr",cluster_id="a8ed8a12b2",} 0.0 ... ``` # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
