[ https://issues.apache.org/jira/browse/SOLR-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742497#comment-17742497 ]
ASF subversion and git services commented on SOLR-16507: -------------------------------------------------------- Commit 28cbd64787f9852f3a8dae15039383f235235632 in solr's branch refs/heads/branch_9x from David Smiley [ https://gitbox.apache.org/repos/asf?p=solr.git;h=28cbd64787f ] SOLR-16507: SplitShardCmd shouldn't use NodeStateProvider (#1775) Objective is to limit use of NodeStateProvider to where it's best. Co-authored-by: vinayak hegde <vinayakph...@gmail.com> > Remove NodeStateProvider & Snitch > --------------------------------- > > Key: SOLR-16507 > URL: https://issues.apache.org/jira/browse/SOLR-16507 > Project: Solr > Issue Type: Task > Reporter: David Smiley > Assignee: Noble Paul > Priority: Major > Labels: newdev > Time Spent: 3h 10m > Remaining Estimate: 0h > > The NodeStateProvider is a relic relating to the old autoscaling framework > that was removed in Solr 9. The only remaining usage of it is for > SplitShardCmd to check the disk space. For this, it could use the metrics > api. > I think we'll observe that Snitch and other classes in > org.apache.solr.common.cloud.rule can be removed as well, as it's related to > NodeStateProvider. > Only > org.apache.solr.cluster.placement.impl.AttributeFetcherImpl#getMetricSnitchTag > and org.apache.solr.cluster.placement.impl.NodeMetricImpl refer to some > constants in the code to be removed. Those constants could move out, > consolidated somewhere we think is appropriate. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org