tflobbe commented on code in PR #1706:
URL: https://github.com/apache/solr/pull/1706#discussion_r1239144094


##########
solr/benchmark/src/resources/configs/cloud-minimal/conf/schema.xml:
##########
@@ -44,11 +44,16 @@
     <dynamicField name="*_b" type="boolean" indexed="true" stored="true"/>
     <dynamicField name="*_s" type="string" indexed="true" stored="false"/>
     <dynamicField name="*_t" type="text" indexed="true" stored="false"/>
-    <dynamicField name="*_i" type="int" indexed="false" stored="false"/>

Review Comment:
   Good call, I thought about it when I changed the schema but I forgot after. 
   I've updated `JsonFaceting` test to use the dv + indexed field (used to be 
dv only). Should be no difference. `CloudIndexing` was using the non-indexed 
fields which is strange to me, maybe the schema was updated after the test or 
maybe the test was focusing just on the distribution? I left it using the 
indexed fields now, which is more realistic, if someone is trying to test 
something in particular with non-indexed fields they can update again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to