epugh commented on code in PR #1688:
URL: https://github.com/apache/solr/pull/1688#discussion_r1216911634


##########
solr/core/src/java/org/apache/solr/packagemanager/PackageUtils.java:
##########
@@ -268,17 +270,8 @@ public static void print(String color, Object message) {
   }
 
   public static String[] validateCollections(String collections[]) {

Review Comment:
   out of curisioty, is this method `validateCollections` called from multiple 
places?  If not, maybe best to just eliminate it all together ;-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to