[
https://issues.apache.org/jira/browse/SOLR-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727750#comment-17727750
]
David Smiley commented on SOLR-14630:
-------------------------------------
It occurred to me we should have mentioned you Jason in CHANGES.txt as it was
your test (probably modified). Not too late, will add; thanks again! BTW I'm
just looking to see that tests are happy before back-porting to be very
cautious. As you may observe from the PR, we debated how to test it.
Personally I'm a fan of distributed-tracing's MockTracer for this sort of
thing. Any way, I don't consider TRACK or tracing a hack approach at all!
There will certainly be no back-ports. main/10x + 9x is where new changes go.
If it were easier to release 8x (it was before the split), we might entertain
bad bug fixes. Some people put commits there anyway but don't expect a
release. Before 8 -- forget about it. And besides, this is a perf
optimization really; it functioned correctly and still does.
> CloudSolrClient doesn't pick correct core when server contains more shards
> --------------------------------------------------------------------------
>
> Key: SOLR-14630
> URL: https://issues.apache.org/jira/browse/SOLR-14630
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud, SolrJ
> Affects Versions: 8.5.1, 8.5.2
> Reporter: Ivan Djurasevic
> Assignee: David Smiley
> Priority: Major
> Attachments:
> 0001-SOLR-14630-Test-case-demonstrating-_route_-is-broken.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Precondition: create collection with 4 shards on one server.
> During search and update, solr cloud client picks wrong core even _route_
> exists in query param. In BaseSolrClient class, method sendRequest,
>
> {code:java}
> sortedReplicas.forEach( replica -> {
> if (seenNodes.add(replica.getNodeName())) {
> theUrlList.add(ZkCoreNodeProps.getCoreUrl(replica.getBaseUrl(),
> joinedInputCollections));
> }
> });
> {code}
>
> Previous part of code adds base url(localhost:8983/solr/collection_name) to
> theUrlList, it doesn't create core address(localhost:8983/solr/core_name). If
> we change previous code to:
> {quote}
> {code:java}
> sortedReplicas.forEach(replica -> {
> if (seenNodes.add(replica.getNodeName())) {
> theUrlList.add(replica.getCoreUrl());
> }
> });{code}
> {quote}
> Solr cloud client picks core which is defined with _route_ parameter.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
