[ 
https://issues.apache.org/jira/browse/SOLR-11206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727207#comment-17727207
 ] 

Eric Pugh commented on SOLR-11206:
----------------------------------

Note to self, the patch file from 2017 may still have some value when it comes 
to moving arg parsing logic into java ;-)

> Migrate logic from bin/solr scripts to SolrCLI
> ----------------------------------------------
>
>                 Key: SOLR-11206
>                 URL: https://issues.apache.org/jira/browse/SOLR-11206
>             Project: Solr
>          Issue Type: Improvement
>          Components: scripts and tools
>            Reporter: Jason Gerlowski
>            Priority: Major
>         Attachments: SOLR-11206.patch, SOLR-11206.patch, 
> ctrl-script-output-benchmark.cmd, ctrl-script-output-benchmark.sh, 
> linux-initial-output.txt, windows-initial-output.txt
>
>
> The {{bin/solr}} and {{bin/solr.cmd}} scripts have taken on a lot of logic 
> that would be easier to maintain if it was instead written in Java code, for 
> a handful of reasons
> * Any logic in the control scripts is duplicated in two places by definition.
> * Increasing test coverage of this logic would be much easier if it was 
> written in Java.
> * Few developers are conversant in both bash and Windows-shell, making 
> editing difficult.
> Some sections in these scripts make good candidates for migration to Java.  
> This issue should examine any of these that are brought up.  However the 
> biggest and most obvious candidate for migration is the argument parsing, 
> validation, usage/help text, etc. for the commands that don't directly 
> start/stop Solr processes (i.e. the "create", "delete", "zk", "auth", 
> "assert" commands).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to