dsmiley commented on code in PR #1646: URL: https://github.com/apache/solr/pull/1646#discussion_r1204201305
########## solr/CHANGES.txt: ########## @@ -159,6 +159,11 @@ Optimizations * SOLR-16764: Clarify that ExportTool exports documents in JSON with Lines format, not standard JSON. Add explicit -compress option for gzipping output. Add ability to specific a directory for output along with a specific file when using -out. (Eric Pugh) +* SOLR-14630: When querying a single collection with `_route_` parameter or `shards.preference` + specified, SolrJ targets directly a replica of the collection (and not the + collection it self) to save a needless HTTP hop. (Pierre Salagnac) Review Comment: It occurred to me that my wording suggestion is sort of wrong. We didn't add a check for those parameters to exist before doing this thing; we merely look at the number of collections. My wording choice was based on when this optimization matters to a user. Let me try again. (BTW "itself" is one word not two). ```suggestion * SOLR-14630: When querying with the `_route_` or `shards.preference` parameter and if there are multiple replicas for a collection on the receiving node, there was sometimes an extra HTTP hop or the non-intended replica may receive the request. SolrJ will now form the URL directly to the intended replica of the collection (and not the collection itself). (Pierre Salagnac, Ivan Djurasevic) ``` (newlines needed) Also included the reporter's name, which is a courtesy for the sometimes non-trivial work filing the JIRA issue and populating it with useful information for us to come along and fix :-). I dropped reference to multiple collections as it's more of an obscure detail that doesn't apply to 95% of people. We try to keep CHANGES.txt brief. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
