[ 
https://issues.apache.org/jira/browse/SOLR-16800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723268#comment-17723268
 ] 

Jason Gerlowski edited comment on SOLR-16800 at 5/16/23 7:58 PM:
-----------------------------------------------------------------

bq. What would look the cleanest?

Idk - I'm a little out-of-date on this part of Solr's interface.  Let me brush 
up a bit and maybe I can chime back in later with a more productive, concrete 
suggestion.

But I think we're going to get ourselves into trouble if bin/solr starts 
expecting different "types" of URLs for its different tools.  Users who set a 
SOLR_URL in solr.in.sh, or "export SOLR_URL=asdf" in their initContainer, or 
pass the same "-url" flag to a bunch of bin/solr commands....well they probably 
expect that URL to work with pretty much all of their bin/solr commands that 
take in a URL.  Anything else is going to be a real Principle of Least Surprise 
problem.

I'm all for having a "-url" parameter.  But using it to get rid of "-c" really 
sets us up for that pitfall by requiring users to provide a different URL than 
they'd give to the other bin/solr tools. 


was (Author: gerlowskija):
bq. What would look the cleanest?

Idk - I'm a little out-of-date on this part of Solr's interface.  Let me brush 
up a bit and maybe I can chime back in later with a more productive, concrete 
suggestion.

But I think we're going to get ourselves into trouble if bin/solr starts 
expecting different "types" of URLs for its different tools.  Users who set a 
SOLR_URL in solr.in.sh, or "export SOLR_URL=asdf" in their initContainer, or 
pass the same "-url" flag to a bunch of bin/solr commands....well they probably 
expect that URL to work with pretty much all of their bin/solr commands that 
take in a URL.  Anything else is going to be a real Principle of Least Surprise 
problem.

I'm all for having a "-url" parameter.  But using it to get rid of "-c" really 
sets us up for that pitfall IMO.

> Allow create_collection to use -url instead of -c and work with remote solr.
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-16800
>                 URL: https://issues.apache.org/jira/browse/SOLR-16800
>             Project: Solr
>          Issue Type: Sub-task
>          Components: cli
>    Affects Versions: main (10.0), 9.3
>            Reporter: Eric Pugh
>            Priority: Minor
>
> We have a mix of commands that take a -url and others that take a -c 
> parameter.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to