rseitz commented on code in PR #1463:
URL: https://github.com/apache/solr/pull/1463#discussion_r1190209903
##########
solr/core/src/java/org/apache/solr/search/ExtendedDismaxQParser.java:
##########
@@ -1275,6 +1270,119 @@ && allSameQueryStructure(lst)) {
}
}
+ /**
+ * Determines whether a list of field-centric queries can be rewritten as
term-centric ones by
+ * regrouping clauses according to startOffset. Requires taht each query
is a BooleanQuery (or
+ * BoostQuery containing a BooleanQuery) with clauses of type
SynonymQueryWithOffset or
+ * TermQueryWithOffset and that each clause has a non-null offset.
+ */
+ private boolean canRewriteUsingStartOffset(List<Query> lst) {
+ for (Query q : lst) {
+
+ Query unwrappedQuery = q;
+ if (q instanceof BoostQuery) {
+ unwrappedQuery = ((BoostQuery) q).getQuery();
+ }
+
+ if (!(unwrappedQuery instanceof BooleanQuery)) {
+ return false;
+ }
+ BooleanQuery bq = (BooleanQuery) unwrappedQuery;
+
+ for (BooleanClause clause : bq.clauses()) {
+ Query innerQuery = clause.getQuery();
+ if (OffsetHolder.getStartOffset(innerQuery) == null) {
+ return false;
+ }
+ }
+ }
+ return true;
+ }
+
+ /**
+ * Rewrites a list of field-centric queries as term-centric queries by
creating a term-centric
+ * query for each unique startOffset found in the clauses inside the
field-centric queries.
+ *
+ * <p>Assumes the list contains only instance BooleanQuery or BoostQuery
containing
+ * BooleanQuery, and that each BooleanQuery has clauses of type
TermQueryWithOffset or
+ * SynonymQueryWithOffset, as confirmed via canRewriteUsingStartOffset()
+ */
+ private BooleanQuery.Builder rewriteUsingStartOffset(List<Query> lst,
float tie) {
+
+ // create a map of startOffsets to the Queries that have a particular
startOffset
+ SortedMap<Integer, List<Query>> offsets = new TreeMap<>();
+ for (Query q : lst) {
+
+ Float boost = null;
+ BooleanQuery bq = null;
+ if (q instanceof BoostQuery) {
+ boost = ((BoostQuery) q).getBoost();
+ bq = (BooleanQuery) ((BoostQuery) q).getQuery();
+ } else {
+ bq = (BooleanQuery) q;
+ }
+
+ for (BooleanClause bc : bq.clauses()) {
+ Query innerQuery = bc.getQuery();
+ int offset = OffsetHolder.getStartOffset(innerQuery);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
