[ 
https://issues.apache.org/jira/browse/SOLR-16773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717326#comment-17717326
 ] 

Chris M. Hostetter commented on SOLR-16773:
-------------------------------------------

>From reading the diff, it looks like it should work – but frankly i feel like 
>the "real" bug is the fact that we're using a regex at all.

The current logic loops over the {{cores}} from {{CLUSTERSTATUS}} and applying 
a regex to {{core['core']}} to munge it into a {{coreMetricName}} key we can 
lookup in {{m.metrics}} to find {{coreMetric = m.metrics[coreMetricName];}}

But all of those {{coreMetric}} entries in {{m.metrics}} have a 
{{"CORE.coreName"}} property.

 

So why don't we instead do a single loop over {{m.metrics}} to build a new Map 
of the entries, keyed off of {{{}coreName{}}}, and do our lookups against that 
- no regex needed.

?

> UI: Cloud>NOdes screen can't display disk usage from replicas using 
> non-standard core names (ie: implicit router)
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-16773
>                 URL: https://issues.apache.org/jira/browse/SOLR-16773
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Chris M. Hostetter
>            Assignee: Jan Høydahl
>            Priority: Major
>         Attachments: implict_router_ui_metrics_bug.png
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Consider the following cluster w/three collections (including the 
> {{gettingstarted}} collection created by the example)...
> {noformat}
> ./solr/packaging/build/dev/bin/solr -e cloud -noprompt
> curl -sS 
> 'http://localhost:8983/solr/admin/collections?action=CREATE&name=named_shards&router.name=compositeId&numShards=2&shards=shardX,shardY'
> curl -sS 
> 'http://localhost:8983/solr/admin/collections?action=CREATE&name=implicit_named_shards&router.name=implicit&shards=shardA,shardB'{noformat}
>  
> If you look at the Cloud>Nodes screen for this cluster, the "Disk Usage" (and 
> other metrics) for the cores from the {{implicit_named_shards}} collection 
> wound show up. (see screenshot)
>  
> The problem is that {{cloud.js}} expects core names to follow a very specific 
> format, but implicit router names it's cores directly after the shard names 
> specified.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to