epugh commented on code in PR #1565:
URL: https://github.com/apache/solr/pull/1565#discussion_r1178224029
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java:
##########
@@ -168,6 +168,12 @@ protected HttpSolrClient(Builder builder) {
this.internalClient = false;
this.followRedirects = builder.followRedirects;
this.httpClient = builder.httpClient;
+ // The getParams() is not supported by this httpClient type! Throws
exception.
+ // this.soTimeout =
builder.httpClient..getIntParameter(HttpClientUtil.PROP_SO_TIMEOUT,
+ // Math.toIntExact(builder.socketTimeoutMillis));
+ // this.connectionTimeout =
+ //
builder.httpClient.getParams().getIntParameter(HttpClientUtil.PROP_CONNECTION_TIMEOUT,
+ // Math.toIntExact(builder.connectionTimeoutMillis));
Review Comment:
Can you push up an exampel of what you mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
