gerlowskija commented on PR #1590: URL: https://github.com/apache/solr/pull/1590#issuecomment-1522017625
With the exception of a few tests that are unique to this PR, the code here all comes from https://github.com/apache/solr/pull/1453. I'm in the process of splitting that PR up into smaller chunks, of which this is one. The code here should be good to go, except for a CHANGES.txt entry I'll add closer to merge-time to avoid the inevitable conflicts that file has. Since the code has been up for review for some weeks under that other PR, I'll probably aim to commit here in the next few days once I'm confident that the tests look good? Fingers crossed I guess... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org