[
https://issues.apache.org/jira/browse/SOLR-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716266#comment-17716266
]
Jason Gerlowski commented on SOLR-16769:
----------------------------------------
bq. Can you please point me to where it was referred to as an internal API? Did
it have @lucene.internal annotation?
Yep. See
[this|https://issues.apache.org/jira/browse/SOLR-16769?focusedCommentId=17715798&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17715798]
screenshot posted by Jan above. Here's my own screenshot from the commit
(019d73) immediately preceding SOLR-16488 on main:
!Screen Shot 2023-04-25 at 8.15.52 AM.png!
bq. That notice makes no mention of the removal of /api/cluster/zk endpoint
Again, I'm not sure what endpoint you're referring to. I believe you that it
existed at some point, but there was no {{/api/cluster/zk}} at the time of
SOLR-16488. Look:
{code}
$ git checkout -b pre-solr-16488 019d732f88750ef69b50731e7c280edc305d3423
Switched to a new branch 'pre-solr-16488'
$ ./gradlew assemble
<truncated>
$ cd /Users/gerlowskija/checkouts/solr/solr/packaging/build/solr-10.0.0-SNAPSHOT
$ bin/solr start -c
<truncated>
$ curl -s -o /dev/null -w "%{http_code}" "http://localhost:8983/api/cluster/zk";
404
{code}
Do you have a commit hash for folks to see the "/api/cluster/zk" you're talking
about?
bq. The best course of action now is to serve both the new and old endpoints
with the same output, and remove the old endpoint in Solr 10.x.
If you guys want to (re-)add an "/api/cluster/zk" to help out YASA (and similar
users), I'm not standing in the way of that. Feel free to add it back.
But I disagree that strict backcompat should be our aim for
internal/experimental endpoints.
And I agree with Jan that it's not even the best way to serve our users. If
our concern is really about giving users the best experience, they'd be much
better served by an API targeting their specific use case (i.e. listing
cluster-level plugins).
> /api/cluster/zk endpoint removed in non-backward compatible manner
> ------------------------------------------------------------------
>
> Key: SOLR-16769
> URL: https://issues.apache.org/jira/browse/SOLR-16769
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: 9.2
> Reporter: Ishan Chattopadhyaya
> Priority: Blocker
> Fix For: 9.3
>
> Attachments: Screen Shot 2023-04-25 at 8.15.52 AM.png, Skjermbilde
> 2023-04-24 kl. 15.09.38.png
>
>
> In https://issues.apache.org/jira/browse/SOLR-16488, backward compatability
> has been broken when the above mentioned endpoint was removed.
> I think right way should be to retain the older endpoint (deprecated), and
> introduce the new endpoints that are designed to replace it. In 10x, the
> older endpoint can be removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
