[
https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716052#comment-17716052
]
Alessandro Benedetti edited comment on SOLR-16691 at 4/25/23 12:44 AM:
-----------------------------------------------------------------------
I may be wrong but I suspect this merge brought some regressions:
https://github.com/apache/solr/pull/1440
https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/6731/
(not sure why I can't see the previous builds , from 6730 anymore but at a
certain point I saw them and this issue seemed responsible)
I think it was merged but the checks were not all green:
{code:java}
2 of 3 checks passed
@github-actions[bot]
Run Solr Tests using Crave.io resources
Details
@github-actions[bot]
gradle precommit w/ Java 11
Details
@sonatype-lift[bot]
sonatype-lift 3 new bugs, 12 fixed. 1/14 tools failed. Completed in 49 minutes.
D
{code}
Specifically I believe it broke:
{code:java}
ERROR: The following test(s) have failed:
-
org.apache.solr.ltr.feature.TestExternalFeatures.featureExtraction_valueFeatureRequiredInFq_shouldThrowException
(:solr:modules:ltr)
Test output:
/Users/sease/JavaProjects/SeaseFork/solr/solr/modules/ltr/build/test-results/test/outputs/OUTPUT-org.apache.solr.ltr.feature.TestExternalFeatures.txt
Reproduce with: gradlew :solr:modules:ltr:test --tests
"org.apache.solr.ltr.feature.TestExternalFeatures.featureExtraction_valueFeatureRequiredInFq_shouldThrowException"
-Ptests.jvms=8 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC
-XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m"
-Ptests.seed=109CCC23245245D4 -Ptests.file.encoding=UTF-8
-
org.apache.solr.ltr.feature.TestExternalFeatures.featureExtraction_valueFeatureRequired_shouldThrowException
(:solr:modules:ltr)
Test output:
/Users/sease/JavaProjects/SeaseFork/solr/solr/modules/ltr/build/test-results/test/outputs/OUTPUT-org.apache.solr.ltr.feature.TestExternalFeatures.txt
Reproduce with: gradlew :solr:modules:ltr:test --tests
"org.apache.solr.ltr.feature.TestExternalFeatures.featureExtraction_valueFeatureRequired_shouldThrowException"
-Ptests.jvms=8 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC
-XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m"
-Ptests.seed=109CCC23245245D4 -Ptests.file.encoding=UTF-8
- org.apache.solr.ltr.feature.TestExternalFeatures.testEfiFeatureExtraction
(:solr:modules:ltr)
Test output:
/Users/sease/JavaProjects/SeaseFork/solr/solr/modules/ltr/build/test-results/test/outputs/OUTPUT-org.apache.solr.ltr.feature.TestExternalFeatures.txt
Reproduce with: gradlew :solr:modules:ltr:test --tests
"org.apache.solr.ltr.feature.TestExternalFeatures.testEfiFeatureExtraction"
-Ptests.jvms=8 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC
-XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m"
-Ptests.seed=109CCC23245245D4 -Ptests.file.encoding=UTF-8
FAILURE: Build failed with an exception.
{code}
And some additional tests that came with a commit of ours just after this
was (Author: alessandro.benedetti):
I may be wrong but I suspect this merge brought some regressions:
https://github.com/apache/solr/pull/1440
https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/6731/
(not sure why I can't see the previous builds , from 6730 anymore but at a
certain point I saw them and this issue seemed responsible)
I think it was merged but the checks were not all green:
{code:java}
2 of 3 checks passed
@github-actions[bot]
Run Solr Tests using Crave.io resources
Details
@github-actions[bot]
gradle precommit w/ Java 11
Details
@sonatype-lift[bot]
sonatype-lift 3 new bugs, 12 fixed. 1/14 tools failed. Completed in 49 minutes.
D
{code}
> Use Jackson for JSON serialization
> ----------------------------------
>
> Key: SOLR-16691
> URL: https://issues.apache.org/jira/browse/SOLR-16691
> Project: Solr
> Issue Type: Task
> Reporter: Noble Paul
> Assignee: Noble Paul
> Priority: Major
> Fix For: 9.3
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> A user has reported significant performance gains from using Jackson over our
> homegrown JSON writer
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
