patsonluk commented on PR #1477: URL: https://github.com/apache/solr/pull/1477#issuecomment-1520478105
> Many thanks for the review @noblepaul ! I have added another small commit https://github.com/apache/solr/pull/1477/commits/4752028b0c8a741b3e1a2ba91627225200c3c9b6 that adds javadoc and make the changed DocCollection ctor private - to ensure dev calls `DocCollection#buildDocCollection` in the future. If it's all good, would you mind to merge the changes? Or do we also need to add items to the release notes? Many thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
