alessandrobenedetti commented on code in PR #1586:
URL: https://github.com/apache/solr/pull/1586#discussion_r1175493812
##########
solr/modules/ltr/src/java/org/apache/solr/ltr/SolrQueryRequestContextUtils.java:
##########
@@ -54,18 +57,22 @@ public static LTRScoringQuery[]
getScoringQueries(SolrQueryRequest req) {
}
/** isExtractingFeatures flag accessors */
- public static void setIsExtractingFeatures(SolrQueryRequest req) {
- req.getContext().put(IS_EXTRACTING_FEATURES, Boolean.TRUE);
+ public static void enableFeatureLogging(SolrQueryRequest req) {
+ req.getContext().put(IS_LOGGING_FEATURES, Boolean.TRUE);
}
- public static void clearIsExtractingFeatures(SolrQueryRequest req) {
- req.getContext().put(IS_EXTRACTING_FEATURES, Boolean.FALSE);
+ public static boolean isLoggingFeatures(SolrQueryRequest req) {
+ return Boolean.TRUE.equals(req.getContext().get(IS_LOGGING_FEATURES));
}
- public static boolean isExtractingFeatures(SolrQueryRequest req) {
- return Boolean.TRUE.equals(req.getContext().get(IS_EXTRACTING_FEATURES));
+ public static void logAllFeatures(SolrQueryRequest req, Boolean logAll) {
Review Comment:
this one I am not sure, I think the name can be reasonable without the
explicit set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
