risdenk commented on code in PR #1482:
URL: https://github.com/apache/solr/pull/1482#discussion_r1146210036
##########
solr/solrj/src/java/org/apache/solr/common/util/Utils.java:
##########
@@ -110,8 +110,8 @@ public static Map getDeepCopy(Map<?, ?> map, int maxDepth,
boolean mutable, bool
} else {
copy =
map instanceof LinkedHashMap
- ? new LinkedHashMap<>(map.size())
- : new HashMap<>(map.size());
+ ? CollectionUtil.newLinkedHashMap(map.size())
Review Comment:
Hmm I see your point, but there are a variety of deepCopy methods that
aren't all working on collections so I think it makes sense to leave them
separate from CollectionUtil.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
