risdenk commented on code in PR #1256:
URL: https://github.com/apache/solr/pull/1256#discussion_r1137365537
##########
solr/core/src/test/org/apache/solr/cloud/MigrateRouteKeyTest.java:
##########
@@ -105,7 +105,6 @@ public void multipleShardMigrateTest() throws Exception {
CollectionAdminRequest.createCollection("sourceCollection", "conf", 2, 1)
Review Comment:
`"sourceCollection"` should be a variable just like targetcollection
##########
solr/core/src/test/org/apache/solr/cloud/api/collections/ShardSplitTest.java:
##########
@@ -76,7 +77,7 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-@LuceneTestCase.Nightly
+// @LuceneTestCase.Nightly
Review Comment:
Hm?
##########
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##########
@@ -2283,6 +2292,26 @@ protected CloudSolrClient getCommonCloudSolrClient() {
return commonCloudSolrClient;
}
+ protected CloudSolrClient getSolrClientForCollection(String collectionName) {
+ synchronized (this) {
+ if (!solrClientForCollectionCache.containsKey(collectionName)) {
Review Comment:
Did you push up a change @epugh? Still see synchronized
##########
solr/test-framework/src/java/org/apache/solr/cloud/AbstractBasicDistributedZk2TestBase.java:
##########
@@ -325,7 +325,7 @@ private void bringDownShardIndexSomeDocsAndRecover() throws
Exception {
query("q", "*:*", "sort", "n_tl1 desc");
- cloudClient.setDefaultCollection(DEFAULT_COLLECTION);
+ // cloudClient.withDefaultCollection(DEFAULT_COLLECTION);
Review Comment:
remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
