gerlowskija commented on PR #1452: URL: https://github.com/apache/solr/pull/1452#issuecomment-1470094543
I've added some unit tests to cover the testing gap. Thought I'd done that earlier, my mistake. > Also are we adding upgrade notes info for V2 API changes, or just CHANGES.txt entries? I've been sticking to CHANGES.txt entries up to this point whenever a v2 API is added or modified. I hadn't done upgrade notes, primarily because of the evolving nature of the v2 APIs. I don't have a strong opinion either way there - I'd be happy to add an upgrade note that aggregates a lot of the CHANGES.txt entries, if you think that'd be valuable to folks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org