dsmiley commented on code in PR #1440:
URL: https://github.com/apache/solr/pull/1440#discussion_r1136469584
##########
solr/test-framework/src/java/org/apache/solr/SolrTestCase.java:
##########
@@ -183,4 +186,11 @@ public void checkSyspropForceBeforeAssumptionFailure() {
final String PROP = "tests.force.assumption.failure.before";
assumeFalse(PROP + " == true", systemPropertyAsBoolean(PROP, false));
}
+
+ public static void jsonAssert(String expected, String actual) {
Review Comment:
Without looking at the code, the method's name alone gives no hint as to
what is being asserted. Perhaps renaming to assertJsonEquals instead? And
javadocs of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
