[ https://issues.apache.org/jira/browse/SOLR-16676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698004#comment-17698004 ]
Alex Deparvu commented on SOLR-16676: ------------------------------------- thanks Kevin, will be trying this command out to see if it fails for me too. was looking at the jenkins builds and it's not failing reliably as far as I can see, could you confirm? I'm working on a fix but would like to understand if this is blocking anyone. > Http2SolrClient loss of MDC context > ----------------------------------- > > Key: SOLR-16676 > URL: https://issues.apache.org/jira/browse/SOLR-16676 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrJ > Affects Versions: 9.0, 9.1 > Reporter: Alex Deparvu > Priority: Minor > Fix For: 9.2 > > Time Spent: 3h 40m > Remaining Estimate: 0h > > The Http2SolrClient loses MDC context information when running an async > request in Solr 9.x. > The issue is the 'Request#send' [0] call is actually async itself and by the > time the response listener kicks in to push the response processing to the > executor the MDC context is already lost, so the executor will no longer have > access to the original MDC in order to push it forward onto the thread that > will process the response. > > This is very difficult to capture on a running system, there are no logs > during this window. I only saw it because I was specifically looking at > thread names for a different reason. > This is how it is reflected in the thread names: > - how it should be (Solr 8 style. containing all MDC data): > {quote}{{httpShardExecutor-5-thread-19-processing-gettingstarted_shard2_replica_n2 > core_node5 localhost:8983_solr gettingstarted shard2 localhost-4}} > {quote} > - how it is in Solr 9 (due to no MDC context) > {quote}httpShardExecutor-5-thread-10 > {quote} > I can't tell if there is anything breaking due to this. > [0] > [https://github.com/apache/solr/blob/7eee7a8ad3c43db0dc26c663dd16764d1fb3dbf4/solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java#L458] -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org