[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1412: SOLR-16372: Migrate collection listing, deletion to JAX-RS

[via GitHub]

sonatype-lift[bot] commented on code in PR #1412:
URL: https://github.com/apache/solr/pull/1412#discussion_r1121868010


##########
solr/core/src/java/org/apache/solr/api/V2HttpCall.java:
##########
@@ -149,6 +149,11 @@ public void call(SolrQueryRequest req, SolrQueryResponse 
rsp) {
                 SolrException.ErrorCode.BAD_REQUEST, "no such collection or 
alias");
           }
         } else {
+          // Certain HTTP methods are only used for admin APIs, check for 
those and short-circuit
+          if 
(List.of("delete").contains(req.getMethod().toLowerCase(Locale.ROOT))) {
+            initAdminRequest(path);

Review Comment:
   <picture><img alt="6% of developers fix this issue" 
src="https://lift.sonatype.com/api/commentimage/fixrate/6/display.svg";></picture>
   
   <b>*THREAD_SAFETY_VIOLATION:</b>*  Unprotected write. Non-private method 
`V2HttpCall.init()` indirectly writes to field `this.action` outside of 
synchronization.
    Reporting because the current class is annotated `@ThreadSafe`, so we 
assume that this method can run in parallel with other non-private methods in 
the class (including itself).
   
   ---
   
   <details><summary>ℹ️ Expand to see all <b>@sonatype-lift</b> 
commands</summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   <b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b>
   
   Was this a good recommendation for you? <sub><small>Answering this survey 
will not impact your Lift settings.</small></sub>
   
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=417107784&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=417107784&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=417107784&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=417107784&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=417107784&lift_comment_rating=5)
 ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org