cpoerschke commented on code in PR #1378:
URL: https://github.com/apache/solr/pull/1378#discussion_r1116715277
##########
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java:
##########
@@ -571,6 +572,57 @@ public void testGetEmptyResults() throws Exception {
assertEquals(0, out.get(1).size());
}
+ @Test
+ public void testMatchAllPaging() throws Exception {
+ SolrClient client = getSolrClient();
+
+ // Empty the database...
+ client.deleteByQuery("*:*"); // delete everything!
+ if (random().nextBoolean()) {
+ client.commit();
+ }
+ // Add eleven docs
+ List<SolrInputDocument> docs = new ArrayList<>();
+ for (int i = 0; i < 11; i++) {
+ SolrInputDocument doc = new SolrInputDocument();
+ doc.addField("id", "id" + i);
+ doc.addField("name", "doc" + i);
+ doc.addField("price", "" + i);
+ docs.add(doc);
+ if (rarely()) {
+ client.commit();
Review Comment:
Is `client.add(docs);` need here and optionally `docs.clear()` after?
```suggestion
client.add(docs);
client.commit();
// docs.clear();
```
##########
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java:
##########
@@ -571,6 +572,57 @@ public void testGetEmptyResults() throws Exception {
assertEquals(0, out.get(1).size());
}
+ @Test
+ public void testMatchAllPaging() throws Exception {
+ SolrClient client = getSolrClient();
+
+ // Empty the database...
+ client.deleteByQuery("*:*"); // delete everything!
+ if (random().nextBoolean()) {
+ client.commit();
+ }
+ // Add eleven docs
+ List<SolrInputDocument> docs = new ArrayList<>();
+ for (int i = 0; i < 11; i++) {
+ SolrInputDocument doc = new SolrInputDocument();
+ doc.addField("id", "id" + i);
+ doc.addField("name", "doc" + i);
+ doc.addField("price", "" + i);
+ docs.add(doc);
+ if (rarely()) {
+ client.commit();
+ }
+ }
+ client.add(docs);
+ if (random().nextBoolean()) {
+ client.commit();
+ } else {
+ client.optimize();
+ }
+ final List<String> sorts = Arrays.asList("_docid_", "id", "name", "price",
null);
+ Collections.shuffle(sorts, random());
+ final List<Integer> starts = Arrays.asList(0, 1, 2, 10, 11, 12);
+ Collections.shuffle(starts, random());
+ for (String sort : sorts.subList(0, 1 + random().nextInt(sorts.size() -
1))) {
+ for (int start : starts.subList(0, 1 + random().nextInt(starts.size() -
1))) {
+ final SolrQuery query = new SolrQuery("*:*");
+ if (sort != null) {
+ query.setSort(sort, random().nextBoolean() ? SolrQuery.ORDER.asc :
SolrQuery.ORDER.desc);
+ }
+ if (start > 0 || random().nextBoolean()) {
+ query.setStart(start);
+ }
+ SolrDocumentList results = client.query(query).getResults();
+ assertEquals(11, results.getNumFound());
+ assertEquals("page from " + start, Math.max(Math.min(10, 11 - start),
0), results.size());
Review Comment:
Hmm, not sure about the `Math.max(Math.min(10, 11 - start), 0)` expression
e.g. for `start=0` it would evaluate to `10` but paging from `0` would return
`11` results, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
