[
https://issues.apache.org/jira/browse/SOLR-16255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693046#comment-17693046
]
Bruno Roustant commented on SOLR-16255:
---------------------------------------
I simply forgot to port it to 9.1, and I just realized now. So changing the fix
version to 9.2.
> Introduce DirectUpdateHandler2#shouldCommit
> -------------------------------------------
>
> Key: SOLR-16255
> URL: https://issues.apache.org/jira/browse/SOLR-16255
> Project: Solr
> Issue Type: Improvement
> Reporter: Bruno Roustant
> Priority: Major
> Fix For: 9.2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently DirectUpdateHandler2 checks IndexWriter.hasUncommittedChanges()
> before effectively calling IndexWriter.commit().
> It is also possible for the user to provide custom commit metadata in the
> CommitUpdateCommand.commitData field.
> The proposed change is to move the check to
> IndexWriter.hasUncommittedChanges() in a new protected method
> DirectUpdateHandler2.shouldCommit(), which would also check (logical or) if
> the CommitUpdateCommand contains user defined commit metadata. It becomes
> possible to commit without change, but with user defined commit metadata.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
