janhoy commented on code in PR #1371:
URL: https://github.com/apache/solr/pull/1371#discussion_r1110436119


##########
solr/webapp/web/partials/collections.html:
##########
@@ -122,8 +124,8 @@
 
     <div id="actions" class="actions clearfix" ng-show="collection">
 
-      <button id="delete-collection" class="warn requires-core" 
ng-click="showDeleteCollection()" ng-show="collection && collection.type === 
'collection'"><span>Delete collection</span></button>
-      <button id="delete-alias" class="action requires-core" 
ng-click="toggleDeleteAlias()" ng-show="collection && collection.type === 
'alias'"><span>Delete alias</span></button>
+      <button id="delete-collection" ng-class="{warn,disabled:!canEditColl}" 
ng-disabled="!canEditColl" ng-click="showDeleteCollection()" 
ng-show="collection && collection.type === 'collection'"><span>Delete 
collection</span></button>
+      <button id="delete-alias" ng-class="{action,disabled:!canEditColl}" 
ng-disabled="!canEditColl" ng-click="toggleDeleteAlias()" ng-show="collection 
&& collection.type === 'alias'"><span>Delete alias</span></button>

Review Comment:
   I removed the `requires-core` class, since I could not find a way to add it 
to this syntax without errors in the console. Don't know what the 
`requires-core` class even does, cannot find it in CSS...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to