gerlowskija commented on PR #1126: URL: https://github.com/apache/solr/pull/1126#issuecomment-1433337997
Morning @Jdurham2843 - I took the liberty of addressing my review comments as they were all relatively minor. I handled each one as a separate commit, so if you happen to disagree on any it should be pretty easy to just revert that one without undoing the others. The largest of these changes was the elimination of the near-duplicate async-processing code from CoreAdminAPIBase.handle and CoreAdminHandler. This was a little tricky but I ended up managing it by having CoreAdminAsyncTracker provide a slightly higher level of abstraction and moving a lot of the duplicated bits (MDC handling, map insertion/removal) internal to that class. Let me know what you think about that approach when you get a chance to look. ---- With my review comments cleared away I've begun testing locally with an eye to commit this soon, so let me know if you have any reservations or anything else you were still hoping to do on this PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
