dweiss commented on code in PR #1320: URL: https://github.com/apache/solr/pull/1320#discussion_r1094174337
########## buildSrc/src/main/java/org/apache/lucene/gradle/GradlePropertiesGenerator.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.gradle; + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.nio.file.StandardOpenOption; +import java.util.Map; +import java.util.stream.Collectors; + +/** + * Standalone class that generates a populated gradle.properties from a template. + * + * <p>Has no dependencies outside of standard java libraries + */ +public class GradlePropertiesGenerator { + public static void main(String[] args) { + if (args.length != 2) { + System.err.println("Usage: java GradlePropertiesGenerator.java <source> <destination>"); + System.exit(2); + } + + try { + new GradlePropertiesGenerator().run(Paths.get(args[0]), Paths.get(args[1])); + } catch (Exception e) { + System.err.println("ERROR: " + e.getMessage()); + System.exit(3); + } + } + + public void run(Path source, Path destination) throws IOException { + if (!Files.exists(source)) { + throw new IOException("template file not found: " + source); + } + if (Files.exists(destination)) { + System.out.println(destination + " already exists, skipping generation."); + } + + // Approximate a common-sense default for running gradle/tests with parallel + // workers: half the count of available cpus but not more than 12. + var cpus = Runtime.getRuntime().availableProcessors(); + var maxWorkers = (int) Math.max(1d, Math.min(cpus * 0.5d, 12)); + var testsJvms = (int) Math.max(1d, Math.min(cpus * 0.5d, 12)); + + var replacements = Map.of("org.gradle.workers.max", maxWorkers, "tests.jvms", testsJvms); + + // Java properties doesn't preserve comments, so going line by line instead + // The properties file isn't big, nor is the map of replacements, so not worrying about speed Review Comment: This will work for simple values (and property names) but not when property values are more complex characters - these should (in theory at least) be escaped and/or encoded to plain ascii. I don't think it's a problem for now. ########## help/localSettings.txt: ########## @@ -1,62 +0,0 @@ -Local developer settings -======================== - -The first invocation of any task in Solr gradle build will generate Review Comment: I think there is some value in leaving (some content) of this file under help/ - so that folks know that this file can be tweaked and is generated? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
