colvinco opened a new pull request, #1321: URL: https://github.com/apache/solr/pull/1321
https://issues.apache.org/jira/browse/SOLR-13396 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description This is a fix for SOLR-13396 to prevent the automatic deletion of cores that aren't referenced in the ZK Clusterstate. It's a Draft at the moment, as it still needs a test and some other changes, but I'm hoping we can get a general agreement on fixing this. # Solution I've added a system property and associated ENV flags to determine whether unreferenced cores should be deleted. This is a simple fix that should work for most people who have had an issue with SOLR-13396 (simply disabling the automatic deletion). A "better" fix may exist in the form of adding additional safety checks to try and detect misconfiguration, but this still feels like a safe option to have in addition to that in any case. Currently I've not changed the default behavior, so cores will still be deleted automatically OOTB. I've therefore named the property `preserveUnknownCores` and the env `SOLR_PRESERVE_UNKNOWN_CORES`. I would prefer to flip the default behavior to no longer automatically delete (and I know others would too), and instead have a `deleteUnknownCores` property. However I appreciate that that would be a change to the behavior introduced in SOLR-12066, so I'm not proposing that currently. # Tests TODO: Still need to add tests, but I don't know what the best approach is. I've found the test that was added for SOLR-12066 (https://github.com/apache/solr/blob/main/solr/core/src/test/org/apache/solr/cloud/DeleteInactiveReplicaTest.java) but I don't know if I should add a new case to cover this or create a separate test. Also I think it might be best to test this by connecting to a different zookeeper / wrong chroot as part of the test, but I don't know how best to do that with the test scaffolding in use. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x ] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
