tylerbertrand opened a new pull request, #1319: URL: https://github.com/apache/solr/pull/1319
# Description <!-- Please provide a short description of the changes you're making with this pull request. --> Addressed various build script problems uncovered by Gradle Enterprise that should result in improved build times. The following build scans show "before and after" build times and other stats for these changes: * Before: https://scans.gradle.com/s/hxh3ugogtrqv4 * After: https://scans.gradle.com/s/fnusdvrk4xbkm # Solution <!-- Please provide a short description of the approach taken to implement your solution. --> * Resolved overlapping outputs issue caused by `copyTestResources` outputs overlapping with `processTestResources`. Removed `copyTestResources` and moved its functionality into the existing `processTestResources` task. Overlapping outputs between these two tasks was causing them both to not be cacheable. * Configured inputs and outputs for `validateJarLicenses` task. Properly configuring task inputs and outputs prevents a task from being needlessly re-executed if its inputs and outputs have not changed. * Converted absolute paths to relative paths where necessary. Implemented `CommandLineArgumentProvider`s to properly configure the problematic input files/directories and their pathing. Referencing certain files/directories by absolute path was causing tasks to be re-executed even though their outputs should've been read from the build cache without re-execution. * Marked some properties as `@Internal`, as they should not be considered for `UP-TO-DATE` checking. * Updated tasks touched by these changes to take advantage of lazy task configuration Lazily configuring tasks avoids wasting time configuring tasks that will not be executed # Tests <!-- Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. --> N/A - only build logic was changed # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
