[
https://issues.apache.org/jira/browse/SOLR-16631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679772#comment-17679772
]
Jan Høydahl commented on SOLR-16631:
------------------------------------
Feel free to submit a PR
> solr.shardsWhitelist solr.allowUrls - hostnames should be treated in case
> insensitive way
> -----------------------------------------------------------------------------------------
>
> Key: SOLR-16631
> URL: https://issues.apache.org/jira/browse/SOLR-16631
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Affects Versions: 9.0, 8.11, 9.1
> Reporter: Paul Blanchaert
> Priority: Minor
>
> Given that hostnames should be case insensitive (see
> [rfc3986;section-6.2.2.1|https://www.rfc-editor.org/rfc/rfc3986#section-6.2.2.1]),
> the check for should also consider hostnames in urls in a case insentive way.
> That is not the case (not in Solr 8 and not after refactoring in Solr 9).
> Most people are using always lowercases for hostnames in urls, so probably
> not encountered that often and there is an easy and quick fix by changing the
> parameter to match the actual cases used in the hostname, hence priority is
> "Minor". But still, it is better to comply with well-established rules.
> Easy test via changing 1 char to uppercase in the hostname of the unit test
> AllowListUrlCheckerTest.testSingleHost().
> E.g. test result:
> org.apache.solr.common.SolrException: URL
> [http://abc-1.Com:8983/solr|http://abc-1.com:8983/solr] is neither a live
> node of the cluster nor in the configured 'allowUrls' [abc-1.com:8983]
> Note: SOLR-15340 renamed solr.shardsWhitelist to solr.allowUrls
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
