risdenk commented on code in PR #1269: URL: https://github.com/apache/solr/pull/1269#discussion_r1061622621
########## solr/modules/hadoop-auth/src/test/org/apache/solr/security/hadoop/KerberosTestServices.java: ########## @@ -198,10 +198,18 @@ public AppConfigurationEntry[] getAppConfigurationEntry(String name) { * These Locales don't generate dates that are compatible with Hadoop MiniKdc. See LocaleTest.java * and https://issues.apache.org/jira/browse/DIRKRB-753 */ - static final List<String> incompatibleLanguagesWithMiniKdc = - Arrays.asList( - "mzn", "ps", "mr", "uz", "ks", "bn", "my", "sd", "pa", "ar", "th", "dz", "ja", "ne", - "ckb", "fa", "lrc", "ur", "ig", "sat", "mni", "sa", "as"); + static final List<String> incompatibleLanguagesWithMiniKdc = getIncompatibleLanguagesWithMiniKdc(); + + private static List<String> getIncompatibleLanguagesWithMiniKdc() { + List<String> locales = Arrays.asList( + "mzn", "ps", "mr", "uz", "ks", "bn", "my", "sd", "pa", "ar", "th", "dz", "ja", "ne", + "ckb", "fa", "lrc", "ur", "ig", "sat", "mni", "sa", "as"); + if (Runtime.version().feature() >= 20) { Review Comment: addressed in 51c6595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org