janhoy commented on PR #1168:
URL: https://github.com/apache/solr/pull/1168#issuecomment-1370580585

   Thanks for the review. I just updated to the latest version of 
opentelementry.
   
   The contents of `modules/opentelemetry/lib/` folder now totals ~10Mb, see 
list below.
   I made an attempt to slim it down by excluding `opentelemetry-sdk-logs`, 
`opentelemetry-sdk-metrics` (since we only use trace), but the 
auto-configuration mode we use to support configuration by ENV variable has 
hard dependencies on them during initialization. Also I thought we could skip 
support for JSON/HTTP and only do protobuf/gRPC (using netty), but for similar 
reasons I could not.
   
   So even if I don't like the weight increase I'm voting for shipping this, 
giving users a choice between transports. Perhaps also in a later release we 
can try to activate OTLP metrics and logs export in this module.
   
   ```
    20K    annotations-13.0.jar
   4.0K    annotations-4.1.1.4.jar
   256K    grpc-api-1.50.2.jar
    32K    grpc-context-1.50.2.jar
   716K    grpc-core-1.50.2.jar
   276K    grpc-netty-1.50.2.jar
   8.0K    grpc-protobuf-1.50.2.jar
   8.0K    grpc-protobuf-lite-1.50.2.jar
    52K    grpc-stub-1.50.2.jar
   260K    gson-2.9.1.jar
   1.5M    kotlin-stdlib-1.7.21.jar
   208K    kotlin-stdlib-common-1.7.21.jar
    48K    kotlin-stdlib-jdk7-1.7.21.jar
    20K    kotlin-stdlib-jdk8-1.7.21.jar
   632K    netty-codec-http-4.1.82.Final.jar
   464K    netty-codec-http2-4.1.82.Final.jar
   120K    netty-codec-socks-4.1.82.Final.jar
    24K    netty-handler-proxy-4.1.82.Final.jar
   768K    okhttp-4.10.0.jar
   344K    okio-jvm-3.0.0.jar
   128K    opentelemetry-api-1.21.0.jar
    12K    opentelemetry-api-logs-1.21.0-alpha.jar
    48K    opentelemetry-context-1.21.0.jar
    88K    opentelemetry-exporter-common-1.21.0.jar
    32K    opentelemetry-exporter-otlp-1.21.0.jar
   108K    opentelemetry-exporter-otlp-common-1.21.0.jar
    32K    opentelemetry-opentracing-shim-1.21.0-alpha.jar
   8.0K    opentelemetry-sdk-1.21.0.jar
    40K    opentelemetry-sdk-common-1.21.0.jar
    48K    opentelemetry-sdk-extension-autoconfigure-1.21.0-alpha.jar
    20K    opentelemetry-sdk-extension-autoconfigure-spi-1.21.0.jar
    44K    opentelemetry-sdk-logs-1.21.0-alpha.jar
   280K    opentelemetry-sdk-metrics-1.21.0.jar
   116K    opentelemetry-sdk-trace-1.21.0.jar
    36K    opentelemetry-semconv-1.21.0-alpha.jar
   8.0K    perfmark-api-0.25.0.jar
   1.7M    proto-google-common-protos-2.9.2.jar
   1.6M    protobuf-java-3.21.12.jar
    20K    solr-opentelemetry-10.0.0-SNAPSHOT.jar
   10M
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to