epugh commented on code in PR #1182:
URL: https://github.com/apache/solr/pull/1182#discussion_r1059415280
##########
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java:
##########
@@ -228,20 +230,20 @@ public List<SolrPackageInstance>
fetchInstalledPackageInstances() throws SolrExc
public Map<String, SolrPackageInstance> getPackagesDeployed(String
collection) {
Map<String, String> packages = null;
try {
- NavigableObject result =
- (NavigableObject)
- Utils.executeGET(
- solrClient.getHttpClient(),
- solrBaseUrl
- + PackageUtils.getCollectionParamsPath(collection)
- + "/PKG_VERSIONS?omitHeader=true&wt=javabin",
- Utils.JAVABINCONSUMER);
+ Map<String, String[]> paramsMap = new LinkedHashMap<>();
+ paramsMap.put("omitHeader", new String[] {"true"});
+ paramsMap.put("wt", new String[] {"javabin"});
+ NamedList<Object> result =
+ solrClient.request(
+ new GenericSolrRequest(
+ SolrRequest.METHOD.GET,
+ PackageUtils.getCollectionParamsPath(collection) +
"/PKG_VERSIONS",
+ new ModifiableSolrParams(paramsMap)));
packages =
(Map<String, String>)
result._get("/response/params/PKG_VERSIONS",
Collections.emptyMap());
- } catch (PathNotFoundException ex) {
- // Don't worry if PKG_VERSION wasn't found. It just means this
collection was never touched by
- // the package manager.
Review Comment:
Do we need to keep this comment? Did we lose the fact that it's okay to
not have a PKG_VERSIONS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
